Nice find @eXpl0it3r ! I don't think this should be an opt it. The intent of the library is to match Microsoft.Extensions.DependencyInjection in behavior and MEDI disposes factory results by-default.

I suspect most users are unintentionally leaking memory because of this issue.

Do you mind changing the PR so the behavior is unconditional?

I think, you might have highlighted the wrong person. 😄

#181 fixed the pipeline issues and should also still work with netcoreapp3.1 though one should keep an eye on #148

Best to rebase this PR onto main and drop the pipeline fixing commits.

@pakrym For sure I can work on making this on by default. I would love to keep the ability to opt out of dispose here. Currently I'm not aware of a possibility to let jab register a class with multiple interfaces. Therefore I use the factory approach to circumvent this. However in doing so I would end up disposing an instance multiple times which is why I would prefer to keep the ability for the user to control whether jab owns the instance or not.

My bad @sensslen!

Thank you for you contribution!

Do your classes throw when disposed multiple times?

The general recommendation is that multiple disposal should be safe:

If an object's Dispose method is called more than once, the object must ignore all calls after the first one. The object must not throw an exception if its Dispose method is called multiple times.

https://learn.microsoft.com/en-us/dotnet/api/system.idisposable.dispose?view=net-9.0&redirectedfrom=MSDN#remarks

My bad @sensslen!

Thank you for you contribution!

Do your classes throw when disposed multiple times?

The general recommendation is that multiple disposal should be safe:

If an object's Dispose method is called more than once, the object must ignore all calls after the first one. The object must not throw an exception if its Dispose method is called multiple times.

https://learn.microsoft.com/en-us/dotnet/api/system.idisposable.dispose?view=net-9.0&redirectedfrom=MSDN#remarks

No, they don't - It just feels like wasteful to keep these instances even though their disposal has already been taken care of....

PR updated

Thank you!